Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to waitress 3.x and flask-cors 5.x #3838

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

luigiw
Copy link
Member

@luigiw luigiw commented Oct 30, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Oct 30, 2024

promptflow SDK CLI Azure E2E Test Result hancwang/waitress-3

  4 files    4 suites   4m 21s ⏱️
244 tests 204 ✅  40 💤 0 ❌
976 runs  816 ✅ 160 💤 0 ❌

Results for commit 325f322.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 30, 2024

SDK CLI Global Config Test Result hancwang/waitress-3

6 tests   6 ✅  1m 22s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 325f322.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 30, 2024

SDK CLI Test Result hancwang/waitress-3

    4 files      4 suites   1h 5m 5s ⏱️
  790 tests   767 ✅ 23 💤 0 ❌
3 160 runs  3 068 ✅ 92 💤 0 ❌

Results for commit 325f322.

♻️ This comment has been updated with latest results.

@luigiw luigiw changed the title Upgrade to waitress 3.x Upgrade to waitress 3.x and flask-cors 5.x Nov 4, 2024
@singankit singankit merged commit f4afc7e into main Nov 11, 2024
28 checks passed
@singankit singankit deleted the hancwang/waitress-3 branch November 11, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants