Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "accent smoke" theme color #5448

Merged
merged 1 commit into from
Jan 31, 2024
Merged

add "accent smoke" theme color #5448

merged 1 commit into from
Jan 31, 2024

Conversation

eanders-ms
Copy link
Collaborator

Used by teacher tool. I only added it to header bar color set for now. Will add to the others later.

@eanders-ms eanders-ms requested a review from a team January 31, 2024 16:01
@eanders-ms eanders-ms self-assigned this Jan 31, 2024
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine, but what is an "accent smoke" is this a common term in design? Or are we using the term "smoke" because the color would be the result of smoke going on top of the specified color?

@eanders-ms
Copy link
Collaborator Author

eanders-ms commented Jan 31, 2024

The change looks fine, but what is an "accent smoke" is this a common term in design? Or are we using the term "smoke" because the color would be the result of smoke going on top of the specified color?

The borrowed the term "smoke" from the Xbox Design System, which borrows a lot from Fluent. Smoke is one component that makes up the Acrylic effect in Xbox and Fluent. I chose the term because it describes the mood this color should express, a smokey version of the given root color. To make a color smokey: desaturate it but not all the way to grayscale, then lighten or darken as appropriate to bring its luminosity into the .65-.75 range.

The complement of smoke is fog. I don't know if we'll need to introduce fog, but it's just brightened smoke.

image

@eanders-ms eanders-ms merged commit 8d3a0f4 into master Jan 31, 2024
7 checks passed
@eanders-ms eanders-ms deleted the eanders-ms/accent-smoke branch January 31, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants