Reroute cloud through IPC channel #10285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| protected handleResponse(response: pxt.editor.CloudProxyResponse) { | ||
| if (this.pendingMessages[response.id]) { | ||
| this.pendingMessages[response.id](response); |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 18 days ago
To fix the problem, we need to validate that response.id corresponds to a valid function in this.pendingMessages before invoking it. This can be done by checking if response.id exists in this.pendingMessages and if the corresponding value is a function. If either check fails, we should handle the error appropriately.
Suggested changeset
1
webapp/src/minecraftAuthClient.ts
| @@ -329,5 +329,8 @@ | ||
| protected handleResponse(response: pxt.editor.CloudProxyResponse) { | ||
| if (this.pendingMessages[response.id]) { | ||
| this.pendingMessages[response.id](response); | ||
| const pendingMessageHandler = this.pendingMessages[response.id]; | ||
| if (pendingMessageHandler && typeof pendingMessageHandler === 'function') { | ||
| pendingMessageHandler(response); | ||
| delete this.pendingMessages[response.id]; | ||
| } else { | ||
| console.error(`Invalid response id: ${response.id}`); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to review this just yet; mostly just opening this for visibility. adds an alternate auth client that proxies cloud requests to the parent frame. in the future, i'll swap out the frame implementation with one that talks over the IPC channel to minecraft