Code

OCV first pass#10355

Code

Merged

srietkerk merged 34 commits intomastermicrosoft/pxt:masterfrom srietkerk/ocv-iframemicrosoft/pxt:srietkerk/ocv-iframeCopy head branch name to clipboardFeb 6, 2025

+647-9

Commits

Commits on Dec 12, 2024

• plumbing for showing the feedback iframe

  srietkerk

  committed
  d31eca8

  Copy full SHA for d31eca8

Commits on Dec 19, 2024

• add https flag to the cli to use https when debugging ocv iframe

  srietkerk

  committed
  f55fca2

  Copy full SHA for f55fca2

Commits on Dec 20, 2024

• Merge branch 'master' of https://github.com/microsoft/pxt into srietkerk/ocv-iframe

  srietkerk

  committed
  c705f96

  Copy full SHA for c705f96

• more config, removed functions, changed height and width of iframe

  srietkerk

  committed
  87236db

  Copy full SHA for 87236db

Commits on Jan 14, 2025

• using different modal for the feedback

  srietkerk

  committed
  0593552

  Copy full SHA for 0593552

• added feedback menu item to editor menu

  srietkerk

  committed
  5259143

  Copy full SHA for 5259143

• got rid of iframe border

  srietkerk

  committed
  9354dc2

  Copy full SHA for 9354dc2

Commits on Jan 25, 2025

• some small changes and styling

  srietkerk

  committed
  a764d25

  Copy full SHA for a764d25

Commits on Jan 27, 2025

• added comments

  srietkerk

  committed
  6446b2a

  Copy full SHA for 6446b2a

• move app id to configs

  srietkerk

  committed
  2120588

  Copy full SHA for 2120588

• fix onclose reference

  srietkerk

  committed
  4da2fdc

  Copy full SHA for 4da2fdc

• moved frame url to configs

  srietkerk

  committed
  05d4be7

  Copy full SHA for 05d4be7

• remove tutorial completion feedback for now

  srietkerk

  committed
  816c662

  Copy full SHA for 816c662

• use emoji instead of sui icon

  srietkerk

  committed
  8336f42

  Copy full SHA for 8336f42

• merged master

  srietkerk

  committed
  bab52a2

  Copy full SHA for bab52a2

Commits on Jan 28, 2025

• update iframeelement variable in event listener

  Show description for f905236
  

  srietkerk

  and

  riknoll

  authored
  f905236

  Copy full SHA for f905236

• add space to less file

  Show description for 4a4eb79
  

  srietkerk

  and

  riknoll

  authored
  4a4eb79

  Copy full SHA for 4a4eb79

• another iframe element var change

  Show description for 6c86476
  

  srietkerk

  and

  riknoll

  authored
  6c86476

  Copy full SHA for 6c86476

• moved height, width to less file, fixed some styling

  srietkerk

  committed
  cd43ef9

  Copy full SHA for cd43ef9

• remove redundant jsdoc types

  srietkerk

  committed
  be206b5

  Copy full SHA for be206b5

• use pxt log functions, fix spacing in the event listener

  srietkerk

  committed
  2bb7a05

  Copy full SHA for 2bb7a05

• move emoji out of lf

  srietkerk

  committed
  b209592

  Copy full SHA for b209592

• use lf for the displayed strings for the rating

  srietkerk

  committed
  9438c18

  Copy full SHA for 9438c18

Commits on Jan 30, 2025

• types added

  srietkerk

  committed
  158939c

  Copy full SHA for 158939c

• move types to localtypings and wrap them in a namespace

  srietkerk

  committed
  c714b42

  Copy full SHA for c714b42

• change to using the comment bubble icon

  srietkerk

  committed
  728ebd8

  Copy full SHA for 728ebd8

Commits on Jan 31, 2025

• added types

  srietkerk

  committed
  69ec94d

  Copy full SHA for 69ec94d

Commits on Feb 4, 2025

• actually using feedback kind

  srietkerk

  committed
  9dc5367

  Copy full SHA for 9dc5367

• rename feedback app theme field

  srietkerk

  committed
  3e8c6ba

  Copy full SHA for 3e8c6ba

• move iframe init and posting code to helper function

  srietkerk

  committed
  83b45f8

  Copy full SHA for 83b45f8

• use optional chaining for ondismiss call

  srietkerk

  committed
  980020a

  Copy full SHA for 980020a

• move current theme into send update theme function, update theme options

  srietkerk

  committed
  3b6a3ff

  Copy full SHA for 3b6a3ff

• move questions for rating config to a function

  srietkerk

  committed
  943c493

  Copy full SHA for 943c493

Commits on Feb 5, 2025

• move appid, frame url to apptheme

  srietkerk

  committed
  36c823c

  Copy full SHA for 36c823c