Improved pyright's enforcement of keyword arguments passed within a `… #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class` statement when the class has no custom metaclass or `__init_subclass__` in its hierarchy. In this case, the `object.__init_subclass__` method applies, and it accepts no additional keyword arguments. Also improved the error reporting for `__init_subclass__` in general. This addresses #6403.
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:29:28 - error: No parameter named "total" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:29:7 - error: Incorrect keyword arguments for __init_subclass__ method (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:153:30 - error: No parameter named "total" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:153:7 - error: Incorrect keyword arguments for __init_subclass__ method (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:276:30 - error: No parameter named "total" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:276:7 - error: Incorrect keyword arguments for __init_subclass__ method (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:282:27 - error: No parameter named "total" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/types/manifest.py:282:7 - error: Incorrect keyword arguments for __init_subclass__ method (reportGeneralTypeIssues)
- 8413 errors, 22 warnings, 0 informations
+ 8421 errors, 22 warnings, 0 informations
dd-trace-py (https://github.com/DataDog/dd-trace-py): typechecking got 1.35x faster (95.6s -> 71.0s)
(Performance measurements are based on a single noisy sample)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…class
statement when the class has no custom metaclass orinit_subclassin its hierarchy. In this case, theobject.init_subclassmethod applies, and it accepts no additional keyword arguments. Also improved the error reporting forinit_subclass` in general. This addresses #6403.