Potential fix for bind failure during source file check #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
erictraut
reviewed
Nov 9, 2023
| @@ -1890,12 +1890,16 @@ export class Program { | |||
| return false; | |||
| } | |||
|
|
|||
| if (!this._disableChecker) { | |||
| if (!this._disableChecker && !fileToCheck.sourceFile.isFileDeleted()) { | |||
There was a problem hiding this comment.
I wonder if it would be better to add the check for isFileDeleted() within _bindFile? I guess it depends on whether there are other places that call _bindFile that do not already check for this condition.
There was a problem hiding this comment.
_bindFile actually already checks for this and skips binding if the file is deleted. I was thinking that maybe _bindFile should return a boolean indicating if it actually bound the file or not (instead of doing this check here), so callers could skip calling things that depend upon the bind happening.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
erictraut
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/pylance-release#5097
Saw a potential spot where this problem might occur:
Binding is required but it doesn't happen because a file is skipped. Check is still called in that situation.
Also added more information when binding is required but the check happens anyway.