[PylanceBot] Pull Pylance with Pyright 1.1.377 #8808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PylanceBot
commented
Aug 22, 2024
•
PylanceBot
commented
- Rollback lsp client version and fix settings.json tracking https://github.com/microsoft/pyrx/pull/5622
- Initial support for loc comments https://github.com/microsoft/pyrx/pull/5572, https://github.com/microsoft/pyrx/pull/5586, https://github.com/microsoft/pyrx/pull/5588
- Replace deprecated vsce with @vscode/vsce
- handle missing close paren case https://github.com/microsoft/pyrx/pull/5528
- modified tsconfig.json switching form commonjs to node16
This comment has been minimized.
This comment has been minimized.
bschnurr
reviewed
Aug 22, 2024
This comment has been minimized.
This comment has been minimized.
bschnurr
reviewed
Aug 22, 2024
bschnurr
reviewed
Aug 22, 2024
bschnurr
reviewed
Aug 22, 2024
| createSynthesizedAliasDeclaration, | ||
| getDeclarationsWithUsesLocalNameRemoved, | ||
| getNameNodeForDeclaration, | ||
| resolveAliasDeclaration as resolveAliasDeclarationUtil, | ||
| ResolvedAliasInfo, |
There was a problem hiding this comment.
looks like an eslint difference between pylance and pright.. pyright doesn't have "simple-import-sort/imports" on https://github.com/microsoft/pyrx/pull/1537
bschnurr
reviewed
Aug 22, 2024
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
rchiodo
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.