Fixed bug that results in false positive error when a dataclass field… #9223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is annotated with a class-scoped type variable and includes a default value whose type require bidirectional type inference. This addresses #9222.
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- /tmp/mypy_primer/projects/steam.py/steam/app.py:767:16 - error: Type "Leaderboard[Self@PartialApp[NameT@PartialApp], DisplayNameT@Leaderboard]" is not assignable to return type "Leaderboard[Self@PartialApp[NameT@PartialApp], None]"
- "Leaderboard[Self@PartialApp[NameT@PartialApp], DisplayNameT@Leaderboard]" is not assignable to "Leaderboard[Self@PartialApp[NameT@PartialApp], None]"
- Type parameter "DisplayNameT@Leaderboard" is covariant, but "DisplayNameT@Leaderboard" is not a subtype of "None"
- Type "str* | None" is not assignable to type "None"
- "str*" is not assignable to "None" (reportReturnType)
- /tmp/mypy_primer/projects/steam.py/steam/app.py:788:16 - error: Type "Leaderboard[Self@PartialApp[NameT@PartialApp], DisplayNameT@Leaderboard]" is not assignable to return type "Leaderboard[Self@PartialApp[NameT@PartialApp], None]"
- "Leaderboard[Self@PartialApp[NameT@PartialApp], DisplayNameT@Leaderboard]" is not assignable to "Leaderboard[Self@PartialApp[NameT@PartialApp], None]"
- Type parameter "DisplayNameT@Leaderboard" is covariant, but "DisplayNameT@Leaderboard" is not a subtype of "None"
- Type "str* | None" is not assignable to type "None"
- "str*" is not assignable to "None" (reportReturnType)
- /tmp/mypy_primer/projects/steam.py/steam/channel.py
- /tmp/mypy_primer/projects/steam.py/steam/channel.py:40:9 - error: Argument of type "ClanT@Channel" cannot be assigned to parameter "clan" of type "None" in function "__init__"
- Type "Clan* | None" is not assignable to type "None"
- "Clan*" is not assignable to "None" (reportArgumentType)
- /tmp/mypy_primer/projects/steam.py/steam/channel.py:40:9 - error: Argument of type "GroupT@Channel" cannot be assigned to parameter "group" of type "None" in function "__init__"
- Type "Group* | None" is not assignable to type "None"
- "Group*" is not assignable to "None" (reportArgumentType)
- 8455 errors, 96 warnings, 0 informations
+ 8451 errors, 96 warnings, 0 informations
core (https://github.com/home-assistant/core)
- /tmp/mypy_primer/projects/core/homeassistant/components/shelly/button.py:42:5 - error: Argument of type "(_: _ShellyCoordinatorT@ShellyButtonDescription) -> Literal[True]" cannot be assigned to parameter "supported" of type "(ShellyBlockCoordinator | ShellyRpcCoordinator) -> bool" in function "__init__"
- Type "(_: _ShellyCoordinatorT@ShellyButtonDescription) -> Literal[True]" is not assignable to type "(ShellyBlockCoordinator | ShellyRpcCoordinator) -> bool"
- Parameter 1: type "ShellyBlockCoordinator | ShellyRpcCoordinator" is incompatible with type "_ShellyCoordinatorT@ShellyButtonDescription"
- Type "ShellyBlockCoordinator | ShellyRpcCoordinator" is not assignable to type "_ShellyCoordinatorT@ShellyButtonDescription" (reportArgumentType)
- 22416 errors, 323 warnings, 0 informations
+ 22415 errors, 323 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is annotated with a class-scoped type variable and includes a default value whose type require bidirectional type inference. This addresses #9222.