Fixed bug that results in incorrect evaluation of class variables ass… #9381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igned in an `__init_subclass__` or `__class_getitem__` method. These methods are implicitly class methods even though they are not decorated with `@classmethod`. This addresses microsoft/pylance-release#2781.
|
Diff from mypy_primer, showing the effect of this PR on open source code: ibis (https://github.com/ibis-project/ibis)
- /tmp/mypy_primer/projects/ibis/ibis/common/tests/test_grounds.py:1072:17 - error: Cannot assign to attribute "kwargs" for class "type[Test]*"
- Attribute "kwargs" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/ibis/ibis/common/tests/test_grounds.py:1077:18 - error: Cannot access attribute "kwargs" for class "type[Test2]"
- Attribute "kwargs" is unknown (reportAttributeAccessIssue)
- 7298 errors, 126 warnings, 0 informations
+ 7296 errors, 126 warnings, 0 informations
scikit-learn (https://github.com/scikit-learn/scikit-learn)
- /tmp/mypy_primer/projects/scikit-learn/sklearn/utils/_set_output.py:371:17 - error: Cannot assign to attribute "_sklearn_auto_wrap_output_keys" for class "type[_SetOutputMixin]*"
- Attribute "_sklearn_auto_wrap_output_keys" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/scikit-learn/sklearn/utils/_set_output.py:379:13 - error: Cannot assign to attribute "_sklearn_auto_wrap_output_keys" for class "type[_SetOutputMixin]*"
- Attribute "_sklearn_auto_wrap_output_keys" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/scikit-learn/sklearn/utils/_set_output.py:384:17 - error: Cannot access attribute "_sklearn_auto_wrap_output_keys" for class "type[_SetOutputMixin]*"
- Attribute "_sklearn_auto_wrap_output_keys" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/scikit-learn/sklearn/utils/tests/test_set_output.py:313:13 - error: Cannot assign to attribute "custom_parameter" for class "type[AnotherMixin]*"
- Attribute "custom_parameter" is unknown (reportAttributeAccessIssue)
- 13584 errors, 16 warnings, 0 informations
+ 13580 errors, 16 warnings, 0 informations
attrs (https://github.com/python-attrs/attrs)
- /tmp/mypy_primer/projects/attrs/tests/test_init_subclass.py
- /tmp/mypy_primer/projects/attrs/tests/test_init_subclass.py:20:17 - error: Cannot assign to attribute "param" for class "type[Base]*"
- Attribute "param" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/attrs/tests/test_init_subclass.py:37:17 - error: Cannot assign to attribute "param" for class "type[Base]*"
- Attribute "param" is unknown (reportAttributeAccessIssue)
- 996 errors, 44 warnings, 5 informations
+ 994 errors, 44 warnings, 5 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…igned in an
__init_subclass__or__class_getitem__method. These methods are implicitly class methods even though they are not decorated with@classmethod. This addresses microsoft/pylance-release#2781.