Fix language service panic when file isn't listed in the files field of qsharp.json
#2109
+608
−1,117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld of qsharp.json
minestarks
force-pushed
the
minestarks/doc-not-in-files
branch
from
a3d9843 to
b24e63b
Compare
minestarks
changed the title
files field of qsharp.json
minestarks
requested review from
billti,
idavis,
ScottCarda-MS,
sezna and
swernli
as code owners
swernli
reviewed
Jan 22, 2025
| @@ -436,7 +440,12 @@ fn explicit_files_list() { | |||
| packages: {}, | |||
| }, | |||
| lints: [], | |||
| errors: [], | |||
| errors: [ | |||
There was a problem hiding this comment.
nitpick: I'd prefer duplicating the original test, leaving it as the "confirm no errors in good configuration" test and making the copy a test specific to this new error.
minestarks
commented
Jan 22, 2025
There was a problem hiding this comment.
Sorry about the unrelated changes. There are 2 new test cases here which ARE relevant.
I changed how we format the test output in these files, so that they are readable and only include the information that the tests are concerned with.
I got fed up with the ridiculously long Debug outputs we had been using.
minestarks
commented
Jan 22, 2025
| ); | ||
| } | ||
|
|
||
| #[tokio::test] |
There was a problem hiding this comment.
Here are the 2 new test cases, in case you have trouble finding it in the noise.
swernli
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2090
Notably, this also changes how we treat the
filesfield inqsharp.jsonfor local projects their local dependencies.Previously, if the
qsharp.jsonexplicitly listed anyfiles, that list would take priority and we would skip crawling the directory.With this change: we always crawl the
src/directory and include all found*.qsfiles in the project. But we raise an explicit error to the user if any of those files are missing from thefileslist.