Update ControlType values to match corresponding accessibilityRole values
#14215
+91
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yajur-Grover
changed the title
accessibilityRole values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the control type values of components to corresponding accessibilityRole value.
Type of Change
Why
When the
accessibilityRoleproperty is set on a component, thecontrolTypeproperty should be updated to match the correspondingaccessibilityRolevalue. Currently, for most components, this was not happening, and was shown in the following bug:What
Add functionality to update corresponding control type value based on components' accessibilityRole value.
Screenshots
Before:
After:
Testing
N/A
Changelog
Should this change be included in the release notes: yes
Update the control type values of components to corresponding accessibilityRole value.
Microsoft Reviewers: Open in CodeFlow