If we failed to get a default profile, fail the settings load (#1343)

This stops the crash in #1318.
microsoft · Jun 20, 2019 · 66cb7c4 · mauve · Jun 20, 2019 · DHowett-MSFT
1 parent 2015788
commit 66cb7c4
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp b/src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp
@@ -65,6 +65,11 @@ std::unique_ptr<CascadiaSettings> CascadiaSettings::LoadAll(const bool saveOnLoa
         }
         resultPtr = FromJson(root);
 
+        if (resultPtr->GlobalSettings().GetDefaultProfile() == GUID{})
+        {
+            throw winrt::hresult_invalid_argument();
+        }
+
         if (saveOnLoad)
         {
             // Logically compare the json we've parsed from the file to what