Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise, GPO] Add "Default Terminal app" policy to definition template #18363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

htcfreek
Copy link

@htcfreek htcfreek commented Dec 25, 2024

Summary of the Pull Request

This PR implements a policy definition for setting/enforcing the default terminal application.

image

References and Relevant Issues

GitHub (issues):

Docs:

Detailed Description of the Pull Request / Additional comments

This PR adds a new policy definition to the ADMX templates for settings the default Terminal application in Windows.

Note

This PR does not change any code of Windows, Console Host or WIndows Terminal. It only adds the definiton for a new policy to the templates.

I got the registry values form the documentation and by testing the values.

The policy is only available as user policy because the registry values have to be in HKCU.

The Policy is implemented as preference (not inside the Policy key) and therefore keeps it's value on removing (not configured) it. You can see this in gpedit.msc on the policy symbol and the hint in the description.
image

Validation Steps Performed

Manual testing the policy.

PR Checklist

@htcfreek
Copy link
Author

Can you please assign me.

@htcfreek htcfreek changed the title [Enterprise, GPO] Add GPO to select default Terminal app [Enterprise, GPO] Add "Default Terminal app" policy to definition template Dec 25, 2024
@htcfreek
Copy link
Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 18363 in repo microsoft/terminal

@DHowett
Copy link
Member

DHowett commented Jan 7, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DHowett
Copy link
Member

DHowett commented Jan 7, 2025

So, this is technically a third-party extensibility point. Can the policy support a freeform GUID entry (or GUID pair entry, as it were) for any third party terminals that have onboarded?

@htcfreek
Copy link
Author

htcfreek commented Jan 7, 2025

So, this is technically a third-party extensibility point. Can the policy support a freeform GUID entry (or GUID pair entry, as it were) for any third party terminals that have onboarded?

No. Not in the same policy setting. We need a fixed value data for each drop-down item in the same registry value. And as this is not a real policy in Software\Policies we can't use a dummy enum registry value. It wouldn't be deleted on disabling the policy.

We can only try to implement a second policy definition using two text boxes and hopefully they won't conflict in the .pol file then. (Or we completely switch to text boxes and list the guids in the description.)

I think: If an admin needs a value that doesn't fit to the predefined ones, he can still use the currently documented way with registry gpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Policy to control default Terminal setting
2 participants