-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/service principal entitlement #1253
Feature/service principal entitlement #1253
Conversation
@microsoft-github-policy-service agree company="SWICA GESUNDHEITSORGANISATION" |
Duplicate of #1028 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgschwendswica left some comments others looks good to me. I will take another look once these fixed.
azuredevops/internal/acceptancetests/data_service_principal_test.go
Outdated
Show resolved
Hide resolved
...evops/internal/service/memberentitlementmanagement/resource_service_principal_entitlement.go
Outdated
Show resolved
Hide resolved
...evops/internal/service/memberentitlementmanagement/resource_service_principal_entitlement.go
Outdated
Show resolved
Hide resolved
@xuzhang3 thank you very much for the detailled review. |
Co-authored-by: xuzhang3 <[email protected]>
Co-authored-by: xuzhang3 <[email protected]>
|
@xuzhang3 Thank you for the detailled PR Review! |
All Submissions:
What about the current behavior has changed?
This PR adds the resource azuredevops_service_principal_entitlement and the data data_service_principal which have been missing so far.
This will help improve the overall automation capabilities around ADO.
Issue Number:
#1071
There's also a rather old PR addressing the same issue, however it lacks of the data part:
#1028
Does this introduce a change to
go.mod
,go.sum
orvendor/
?Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information