Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/service principal entitlement #1253

Merged

Conversation

jgschwendswica
Copy link
Contributor

@jgschwendswica jgschwendswica commented Dec 17, 2024

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

This PR adds the resource azuredevops_service_principal_entitlement and the data data_service_principal which have been missing so far.
This will help improve the overall automation capabilities around ADO.

Issue Number:
#1071

There's also a rather old PR addressing the same issue, however it lacks of the data part:
#1028

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

image
image

@jgschwendswica
Copy link
Contributor Author

@microsoft-github-policy-service agree company="SWICA GESUNDHEITSORGANISATION"

@xuzhang3
Copy link
Collaborator

Duplicate of #1028

@xuzhang3 xuzhang3 marked this as a duplicate of #1028 Dec 18, 2024
@xuzhang3 xuzhang3 linked an issue Dec 25, 2024 that may be closed by this pull request
@xuzhang3 xuzhang3 self-assigned this Dec 27, 2024
Copy link
Collaborator

@xuzhang3 xuzhang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgschwendswica left some comments others looks good to me. I will take another look once these fixed.

@jgschwendswica
Copy link
Contributor Author

@xuzhang3 thank you very much for the detailled review.
I've incorporated most of your suggested changes.
There are two leftover's where some additional inputs would be helpful

website/docs/d/service_principal.html.markdown Outdated Show resolved Hide resolved
website/docs/d/service_principal.html.markdown Outdated Show resolved Hide resolved
website/docs/d/service_principal.html.markdown Outdated Show resolved Hide resolved
website/docs/d/service_principal.html.markdown Outdated Show resolved Hide resolved
@xuzhang3 xuzhang3 linked an issue Jan 14, 2025 that may be closed by this pull request
@xuzhang3
Copy link
Collaborator

=== RUN   TestAccServicePrincipalDataSource_Read_HappyPath
=== PAUSE TestAccServicePrincipalDataSource_Read_HappyPath
=== CONT  TestAccServicePrincipalDataSource_Read_HappyPath
--- PASS: TestAccServicePrincipalDataSource_Read_HappyPath (25.53s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        41.932s

=== RUN   TestAccServicePrincipalEntitlement_Create
=== PAUSE TestAccServicePrincipalEntitlement_Create
=== CONT  TestAccServicePrincipalEntitlement_Create
--- PASS: TestAccServicePrincipalEntitlement_Create (12.39s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        13.308s

@xuzhang3 xuzhang3 merged commit 9391e5b into microsoft:main Jan 15, 2025
1 check passed
@jgschwendswica jgschwendswica deleted the feature/service_principal_entitlement branch January 15, 2025 09:27
@jgschwendswica
Copy link
Contributor Author

@xuzhang3 Thank you for the detailled PR Review!
It was a very helpful since i'm Terraform heavy user, but don't have a lot of GO experience so far.
It was fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants