Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overrides for strictRead and strictWrite in BinaryProtocol #548

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Overrides for strictRead and strictWrite in BinaryProtocol #548

merged 9 commits into from
Feb 2, 2024

Conversation

rhappe
Copy link
Contributor

@rhappe rhappe commented Jan 17, 2024 •
edited
Loading

  • Adding overrides for the strictRead and strictWrite in the BinaryProtocol constructor. Before these were defaulted to false and immutable.
  • Tests for beginReadMessage and beginWriteMessage, which utilize the strictRead and strictWrite values.

Fixes #547

benjamin-bader
benjamin-bader approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@benjamin-bader benjamin-bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks very much!

@rhappe
Copy link
Contributor Author

rhappe commented Feb 2, 2024

@microsoft-github-policy-service agree

@benjamin-bader benjamin-bader merged commit 3c6d808 into microsoft:master Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamin-bader benjamin-bader benjamin-bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BinaryProtocol hard-codes strict read/write properties
3 participants
@rhappe @benjamin-bader @MichaelSelsky