-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdflib] new port #43138
base: master
Are you sure you want to change the base?
[sdflib] new port #43138
Conversation
I didn't find sdflib name nor the maintainer on https://repology.org/ This port is needed for update mujoco: |
dce6439
to
ed7a5d7
Compare
When testing usage, the following error occurs:
test.cpp#include <iostream> #include "SdfLib/RealSdf.h" CMakeLists.txtcmake_minimum_required (VERSION 3.8) |
Signed-off-by: Tal Regev <[email protected]>
@MonicaLiu0311 include(CMakeFindDependencyMacro)
find_dependency(glm CONFIG)
find_dependency(spdlog CONFIG)
find_dependency(cereal CONFIG) Can you test the port again? Thank you for your review. |
+install(TARGETS ${PROJECT_NAME} icg EXPORT ${PROJECT_NAME}Config | ||
+ RUNTIME DESTINATION bin | ||
+ ARCHIVE DESTINATION lib | ||
+ LIBRARY DESTINATION lib | ||
+) | ||
+ | ||
+install(EXPORT ${PROJECT_NAME}Config | ||
+ NAMESPACE ${PROJECT_NAME}:: | ||
+ DESTINATION share/sdflib | ||
+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage test passed on x64-windows
(header files found).
If the upstream does not export it, please add "unofficial-"
before the config file.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.