Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zlib-ng] Support zlib compatibility mode #43147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

donny-dont
Copy link
Contributor

Use the value of ZLIB_COMPAT to set the directory used by vcpkg_cmake_config_fixup.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Contributor

dg0yt commented Jan 7, 2025

The recipe here does not (and cannot) offer the ZLIB compat API. So this change cannot be tested in vcpkg CI.

The variable ZLIB_COMPAT is not defined in CMake script mode (portfile). (What you have from your custom triplet is VCPKG_CMAKE_CONFIGURE_OPTIONS, as mentioned in your repo). It could be discussed to add a documented portfile variable to make control from triplet explicit.

@dg0yt
Copy link
Contributor

dg0yt commented Jan 7, 2025

i.e. The triplet can also set ZLIB_COMPAT, but then it shouldn't be necessary to also set VCPKG_CMAKE_CONFIGURE_OPTIONS. It should be wired in the portfile.

@donny-dont
Copy link
Contributor Author

Implementation of using ZLIB_COMPAT in a triplet over at WebKitForWindows/WebKitRequirements#208

@Mengna-Li Mengna-Li added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 7, 2025
ports/zlib-ng/portfile.cmake Outdated Show resolved Hide resolved
donny-dont and others added 2 commits January 7, 2025 09:44
Use the value of `ZLIB_COMPAT` to set the directory used by `vcpkg_cmake_config_fixup`.

Co-authored-by: Kai Pastor <[email protected]>
@Mengna-Li Mengna-Li added the info:reviewed Pull Request changes follow basic guidelines label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants