Skip to content

Commit

Permalink
Old API is no longer used by internal Providers (#14970)
Browse files Browse the repository at this point in the history
* Old API is no longer used by internal Providers

* Old API is only used by codespaces extension
  • Loading branch information
DonJayamanne authored Jan 3, 2024
1 parent 29d0eb7 commit c7a1e1c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/kernels/jupyter/finder/remoteKernelFinderController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { JupyterServerCollection, JupyterServerProvider } from '../../../api';
import { CancellationTokenSource } from 'vscode';
import { traceError } from '../../../platform/logging';
import { IRemoteKernelFinderController } from './types';
import { CodespaceExtensionId } from '../../../platform/common/constants';

@injectable()
export class RemoteKernelFinderController implements IRemoteKernelFinderController, IExtensionSyncActivationService {
Expand Down Expand Up @@ -184,7 +185,10 @@ export class RemoteKernelFinderController implements IRemoteKernelFinderControll
};
const getDisplayNameFromOldApi = async () => {
const displayName = await this.jupyterPickerRegistration.jupyterCollections.find(
(c) => c.extensionId === serverUri.provider.extensionId && c.id === serverUri.provider.id
(c) =>
c.extensionId === serverUri.provider.extensionId &&
c.extensionId === CodespaceExtensionId &&
c.id === serverUri.provider.id
)?.label;
if (displayName) {
// If display name is empty/undefined, then the extension has not yet loaded or provider not yet registered.
Expand Down

0 comments on commit c7a1e1c

Please sign in to comment.