Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of checkboxes on description page #1039

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

RMacfarlane
Copy link
Contributor

@RMacfarlane RMacfarlane commented Mar 8, 2019

Fixes #1038

The css rule for input was too general and was getting applied to them. Also, hides the extraneous bullet points in front of the checkboxes. The HTML returned from the server wraps all of them in <li> with class task-list-item, so fixed by not displaying these as list items

Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RMacfarlane RMacfarlane merged commit cdbba10 into master Mar 19, 2019
@RMacfarlane RMacfarlane deleted the rmacfarlane/checkbox-rendering branch September 6, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists with checkboxes render badly
2 participants