Improve styling for reviews, comments, and blockquotes #209
Conversation
preview-src/index.css
Outdated
| @@ -384,12 +406,18 @@ body .comment-form .form-actions button { | |||
| } | |||
|
|
|||
| .comment-body blockquote { | |||
| margin: 0 7px 0 5px; | |||
| padding: 0 16px 0 10px; | |||
| display: flex; | |||
There was a problem hiding this comment.
For xtermjs/xterm.js#1577, I think this display property makes the blockquote shift down too much:
compared to
I think changing the padding to something like 1px 12px would work, I'm not sure why it collapses when there's no vertical padding
There was a problem hiding this comment.
Thanks! Something weird was happening with the flex property (originally used it to get the paragraph padding to show up). Change it to to a block element and adjusted the padding so it shows up correctly.
There was a problem hiding this comment.
Should work better with list items:
And with longer paragraphs:
preview-src/index.css
Outdated
| @@ -384,12 +406,18 @@ body .comment-form .form-actions button { | |||
| } | |||
|
|
|||
| .comment-body blockquote { | |||
There was a problem hiding this comment.
could you change this to just blockquote? xtermjs/xterm.js#1392 has an example of a blockquote being used in somewhere that's not a comment-body
There was a problem hiding this comment.
👍 Opened the scope so it's for all blockquote elements
preview-src/index.css
Outdated
| @@ -3,11 +3,15 @@ | |||
| * Licensed under the MIT License. See License.txt in the project root for license information. | |||
| *--------------------------------------------------------------------------------------------*/ | |||
|
|
|||
| :root { | |||
There was a problem hiding this comment.
unnecessary space carried from auto indent on enter.
Fixes #194 #195
Before
After
