Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
- Remove AUTHORS file
- Support lineHeight in demo
- Remove jsdoc dependency
- Layering refactors
- Buffer optimizations
- Whitespace/null cell differentiation
- Parser OSC string optimization
- Add missing break to setOption code
- Fix mouse coords when position: fixed is used
- Fix addon typings error
- Dispose atlas when no terminals use it
- Find as you type/incremental searching (+ line cache)

Fixes #65318
  • Loading branch information
Tyriar committed Dec 18, 2018
1 parent cd093ce commit 2b76b62
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"vscode-ripgrep": "^1.2.5",
"vscode-sqlite3": "4.0.5",
"vscode-textmate": "^4.0.1",
"vscode-xterm": "3.10.0-beta1",
"vscode-xterm": "3.10.0-beta4",
"winreg": "^1.2.4",
"yauzl": "^2.9.1",
"yazl": "^2.4.3"
Expand Down
4 changes: 4 additions & 0 deletions src/vs/workbench/parts/terminal/browser/terminalFindWidget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ export class TerminalFindWidget extends SimpleFindWidget {

protected onInputChanged() {
// Ignore input changes for now
const instance = this._terminalService.getActiveInstance();
if (instance !== null) {
instance.findNext(this.inputValue, { regex: this._getRegexValue(), wholeWord: this._getWholeWordValue(), caseSensitive: this._getCaseSensitiveValue(), incremental: true });
}
}

protected onFocusTrackerFocus() {
Expand Down
4 changes: 4 additions & 0 deletions src/vs/workbench/parts/terminal/common/terminal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,10 @@ interface ISearchOptions {
* Whether find should pay attention to case.
*/
caseSensitive?: boolean;
/**
* Whether the search should start at the current search position (not the next row)
*/
incremental?: boolean;
}

export interface ITerminalInstance {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9428,10 +9428,10 @@ vscode-uri@^1.0.6:
resolved "https://registry.yarnpkg.com/vscode-uri/-/vscode-uri-1.0.6.tgz#6b8f141b0bbc44ad7b07e94f82f168ac7608ad4d"
integrity sha512-sLI2L0uGov3wKVb9EB+vIQBl9tVP90nqRvxSoJ35vI3NjxE8jfsE5DSOhWgSunHSZmKS4OCi2jrtfxK7uyp2ww==

[email protected]beta1:
version "3.10.0-beta1"
resolved "https://registry.yarnpkg.com/vscode-xterm/-/vscode-xterm-3.10.0-beta1.tgz#99f8fc269ebe28b791801daaa211b77f36692d6d"
integrity sha512-lofgBHVpisbrCjlXEKB4XTtqpsyzSRJ2KbDwKNVJZ7/44k261rYCIUgK8n5U427txTLwlkFNUG9lkTMaPeGKpA==
[email protected]beta4:
version "3.10.0-beta4"
resolved "https://registry.yarnpkg.com/vscode-xterm/-/vscode-xterm-3.10.0-beta4.tgz#ea8dc4c9675dc4dd50cae431240e161e898fe7bb"
integrity sha512-S8WDoUGjH8D7n7DSpCPZOtgJkqXTJsSeqq6cjXqQHCB0j4d/DM6XO49POMyqylFMxXVbZiDC3NWabnZ2hYcYNg==

[email protected]:
version "6.1.2-preview"
Expand Down

0 comments on commit 2b76b62

Please sign in to comment.