Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command tracking scroll behavior #145241

Closed
Tyriar opened this issue Mar 16, 2022 · 0 comments · Fixed by #145252
Closed

Improve command tracking scroll behavior #145241

Tyriar opened this issue Mar 16, 2022 · 0 comments · Fixed by #145252
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 16, 2022

Current when scrolling to commands in the terminal (cmd+up/down) it will scroll the command to the top of the terminal. We should instead align with breakpoints/outline/go to symbol and improve this considering we're getting a highlight in #46561 which will make the line in question more obvious.

The exact behavior I'll do is:

  • When the command is in the viewport: Don't scroll, just highlight
  • When the command is not in the viewport: Scroll to it and position the command in the first 1/3 or 1/4 of the viewport*

* This aligns with how Go to Symbol does it, breakpoints/outline by contrast goes to the center. I'd argue that for commands, similar to navigating to a symbol, the lower context is much more important and since that gives precedence we should align with that behavior.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Mar 16, 2022
@Tyriar Tyriar added this to the March 2022 milestone Mar 16, 2022
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge Mar 16, 2022
Tyriar added a commit that referenced this issue Mar 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Tyriar @meganrogge and others