Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Command navigation improvements #145627

Closed
3 tasks done
Tyriar opened this issue Mar 21, 2022 · 4 comments
Closed
3 tasks done

Test: Command navigation improvements #145627

Tyriar opened this issue Mar 21, 2022 · 4 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2022

Refs: #46561 #145241, #145240

Complexity: 3

Authors: @Tyriar, @meganrogge

Create Issue


Command navigation in the terminal allows navigating between commands. Historically this has only been bound by default on mac but got new keybindings on Windows and Linux.

image

Please test the following:

  • Command navigation works as expected with cmd+up/down (mac) or ctrl+up/down (linux/windows). It should move the terminal's viewport to show the command in question about 25% down the viewport, of just highlight it if the command is already in the viewport.
  • An outline shows briefly as expected when using command navigation.
  • Ctrl/cmd+shift+up/down should select content from the previous anchor point
  • Test the feature with shell integration enabled and disabled, both should work but results should be better when it's enabled.
@Tyriar Tyriar added this to the March 2022 milestone Mar 21, 2022
@bpasero
Copy link
Member

bpasero commented Mar 22, 2022

Pretty cool 👍

@bpasero bpasero removed their assignment Mar 22, 2022
@bpasero
Copy link
Member

bpasero commented Mar 22, 2022

@Tyriar is there an issue for accessibility already? It looks like when I test this with voice over on, I do not really get meaningful output.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 22, 2022

@bpasero there isn't, there's another feature called navigation mode that uses the same keybindings if a screen reader is enabled which scrolls a single line at a time. I should double check that they still work actually.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 22, 2022

@bpasero it works still, just a minor style issue #145725

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants