Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing the terminal throws off navigation selection #145920

Closed
miguelsolorio opened this issue Mar 23, 2022 · 2 comments · Fixed by #145989
Closed

Clearing the terminal throws off navigation selection #145920

miguelsolorio opened this issue Mar 23, 2022 · 2 comments · Fixed by #145989
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
March 2022

Comments

@miguelsolorio
Copy link
Contributor

Testing #145627

clear

  1. run a lot of commands
  2. type in clear
  3. run more commands
  4. :above: as you navigate around the selection will often highlight the wrong item
@Tyriar
Copy link
Member

Tyriar commented Mar 24, 2022

Looks like we need a similar Windows workaround when clearing a screen when shell integration is disabled as well.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Mar 24, 2022
@Tyriar Tyriar added this to the March 2022 milestone Mar 24, 2022
Tyriar added a commit that referenced this issue Mar 24, 2022
@Tyriar
Clear viewport commands in partial detection on CSI 2/3 J
ab56599 
Fixes #145920
@Tyriar Tyriar mentioned this issue Mar 24, 2022
Merged
@Tyriar
Copy link
Member

Tyriar commented Mar 24, 2022

To verify make sure you do not have shell integration enabled. Note when verifying that the experience after clearing may be a little wonky because of #145917, try not navigating until running clear to workaround that.

@rzhao271 rzhao271 mentioned this issue Mar 24, 2022
Closed
gabritto pushed a commit to gabritto/vscode that referenced this issue Mar 25, 2022
@Tyriar @gabritto
Clear viewport commands in partial detection on CSI 2/3 J
88da524 
Fixes microsoft#145920
@joaomoreno joaomoreno added the verified Verification succeeded label Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

Successfully merging a pull request may close this issue.

Clear viewport commands in partial detection on CSI 2/3 J microsoft/vscode
4 participants
@joaomoreno @Tyriar @meganrogge @miguelsolorio