-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add right sidebar #128599
add right sidebar #128599
Conversation
It will be great to have a pin icon for user to pined the three panel, make it like float panel,thanks |
Hi, what's the progress of this? |
I've been busy with some personal stuff recently, but I am still working on it. Definitely will make it ready for review by the end of September. Solving bugs. |
@wendellhu95 can I help you with something, to fasten the progress? |
Hi! I believe that this feature is roughly implemented and usable by now. I would appreciate a lot if you could report some bugs. Many thanks! ❤️
win32: https://drive.google.com/file/d/171gvmP7JM6MHTMlQmnXtL8plmrPc8qmz/view?usp=sharing Sorry to macOS and Linux users. Please build on this branch on your own. |
downloaded the build and started it up. Could not move the outline to the 3rd panel. It shows the plus sign like it will add it while dragging but when I let go of the mouse button the outline is not added. Same actions will add the outline to the bottom panel. |
@wendellhu95 I am starting to explore the second sidebar option this milestone. I appreciate the work that is done here. I will start by exploring the UX involved in opening up to a second side bar and then start with a prototype. I wanted to let you know as we try to increase the flexibility of our layout, there may be changes under the hood that don't match the direction you have gone here. For that reason, while we may not take this PR, we are working towards a similar goal and I will not hesitate to mention your contributions in release notes as we take them. |
It's great to hear that you are working on this. Looking forward to that! And if there's anything I can help with, do please let me know. Since then, I might stop working on this. Any interested user could build from my branch as a temporary solution (it might already be adequate for daily use) before the official comes out. |
Hi. I've fixed that. You can build from this PR. |
This PR fixes #26777
This PR adds another sidebar (in the opposite position of the existing one) to the workbench. So users could drag views like Outline or Timeline to the second sidebar.
Download Link
win32: https://drive.google.com/file/d/171gvmP7JM6MHTMlQmnXtL8plmrPc8qmz/view?usp=sharing
TODO:
not sure ifnow pretty sure that we should add another activity bar on the right side as wellPreview:
thirdpanelPart.ts.-.vscode.-.Code.-.OSS.Dev.2021-07-14.09-01-30.mp4
More screenshots:
With Panel on the bottom:
With Panel on the right:
Dragging other views into Third Panel:
More screen shots: