Command navigation highlight #145245
Command navigation highlight #145245
Conversation
| registerThemingParticipant((theme: IColorTheme, collector: ICssStyleCollector) => { | ||
| const focusBorderColor = theme.getColor(focusBorder); | ||
|
|
||
| if (focusBorderColor) { |
There was a problem hiding this comment.
as some people mentioned in the UX sync, perhaps this should intentionally be different from the focus border so people aren't expecting the focus behavior?
There was a problem hiding this comment.
we could instead go with the gray that's used for the go to implementations decoration
There was a problem hiding this comment.
This got me to realize it only showed focus border because of my theme:
"editor.symbolHighlightBackground": "#0000",
"editor.symbolHighlightBorder": "#399ef4",Here's what it looks like on Dark+ without that:
Will try that and maybe add theme keys for it too
There was a problem hiding this comment.
Hmm, but an issue there is the background has to be drawn on top for us, so it would obscure the text...
There was a problem hiding this comment.
that looks good to me. couldn't you set the transparency?
Fixes #46561
