Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sixels in integrated terminal #171667

Closed
wants to merge 5 commits into from
Closed

Add support for Sixels in integrated terminal #171667

wants to merge 5 commits into from

Conversation

marvinruder
Copy link
Contributor

This PR adds support for Sixels to the integrated terminal, as proposed in #171666.

@marvinruder
Copy link
Contributor Author

@microsoft-github-policy-service agree

@marvinruder
Copy link
Contributor Author

I am confused regarding the change of yarn’s lockfile – “Prevent yarn.lock changes in PRs” disallows it, but “Monaco Editor checks” cannot pass without an updated lockfile since a dependency was added in the package.json and the job runs yarn with --frozen-lockfile.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused regarding the change of yarn’s lockfile

We don't allow anyone external to make changes to the lockfile as it's difficult to review and someone could use that as a way to inject malicious packages under the rader.

I've been holding off adoption of this because of:

Sixel support and image handling in xterm.js is considered beta quality.

I believe it uses a bunch of internal APIs currently which are likely to break across version updates which would impact our agility negatively.

The discussion around all image support is tracked in xtermjs/xterm.js#614, I think the main blocker is figuring out how to have non-text buffer lines in xterm.js

@Tyriar Tyriar closed this Jan 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants