Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scroll list view on keyboard focus #232644

Merged
merged 24 commits into from
Jan 10, 2025
Merged

scroll list view on keyboard focus #232644

merged 24 commits into from
Jan 10, 2025

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Oct 30, 2024 •
edited
Loading

@meganrogge meganrogge requested a review from roblourens October 30, 2024 17:57
@meganrogge meganrogge marked this pull request as draft October 30, 2024 17:57
@meganrogge meganrogge self-assigned this Oct 30, 2024
@meganrogge meganrogge added this to the November 2024 milestone Oct 30, 2024
@meganrogge meganrogge changed the title scroll on keyboard focus scroll chat list on keyboard focus Oct 30, 2024
@roblourens
Copy link
Member

Looks great, but it looks like it's scrolling even when tabbing to something inside the viewport? I don't think it should do that, and it would still scroll when clicking buttons and things, I think

@meganrogge
Copy link
Contributor Author

meganrogge commented Oct 31, 2024 •
edited
Loading

Crux of the issue: scrollTop and y are wrong for elts below the viewport

@meganrogge meganrogge marked this pull request as ready for review November 1, 2024 04:07
@meganrogge meganrogge enabled auto-merge (squash) November 1, 2024 04:09
@meganrogge meganrogge marked this pull request as draft November 1, 2024 04:29
auto-merge was automatically disabled November 1, 2024 04:29

Pull request was converted to draft

@meganrogge meganrogge marked this pull request as ready for review November 1, 2024 21:21
@meganrogge meganrogge modified the milestones: November 2024, January 2025 Dec 2, 2024
@meganrogge meganrogge enabled auto-merge (squash) January 8, 2025 22:17
@meganrogge meganrogge changed the title scroll chat list on keyboard focus scroll list view on keyboard focus Jan 8, 2025
joyceerhl
joyceerhl previously approved these changes Jan 10, 2025
View reviewed changes
@roblourens roblourens mentioned this pull request Jan 10, 2025
Closed
@meganrogge meganrogge disabled auto-merge January 10, 2025 05:13
@meganrogge meganrogge enabled auto-merge (squash) January 10, 2025 05:13
roblourens
roblourens previously approved these changes Jan 10, 2025
View reviewed changes
@meganrogge meganrogge merged commit be8f9a3 into main Jan 10, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/scroll-top branch January 10, 2025 23:13
@rebornix rebornix mentioned this pull request Jan 22, 2025
Closed
rebornix added a commit that referenced this pull request Jan 22, 2025
@rebornix
fix #238420. revert changes from #232644
522a703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

@joyceerhl joyceerhl joyceerhl left review comments

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@meganrogge @roblourens @joyceerhl