Terminal line selection #47991
Merged
Terminal line selection #47991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minal-line-selection
…minal-line-selection
|
|
|
On precommit (and in the CI test) two of the files I modified failed the hygiene check: File not formatted: src/vs/workbench/parts/terminal/node/terminalCommandTracker.ts However I cannot figure out why this is, as tslint doesn't find any errors and I followed all conventions stemming from the original part of the file I modified. How do I "format" these files that I have modified? |
|
@noahjg works great, just made a few cleanliness commits 👍 |
Tyriar
approved these changes
May 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the following issue:
Suggestion: Allow line selection in terminal #46761
Adds the ability to select next/previous lines in the integrated terminal by calculating the offset between the "cursor" and the selected line and using it to create a marker +/- 1 lines away from the currently selected line. Markers created this way are disposed whenever the current marker is changed, so the existing function of selectToNextCommand and selectToPreviousCommand is not compromised.