Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent opaque highlight color from hiding text #98974

Merged
merged 3 commits into from
Jun 1, 2020

Conversation

ChrisPapp
Copy link
Contributor

@ChrisPapp ChrisPapp commented Jun 1, 2020

This PR fixes #97521

It's a "magic" solution but I understand that this is temporary until the bug in the terminal library is fixed.

@ChrisPapp ChrisPapp force-pushed the highlight_color_97521 branch from e8c3318 to ebd51e1 Compare June 1, 2020 18:53
@ChrisPapp ChrisPapp force-pushed the highlight_color_97521 branch from ebd51e1 to a124cc6 Compare June 1, 2020 18:55
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it 50% so the text is a little more visible, thanks!

@Tyriar Tyriar added this to the May 2020 milestone Jun 1, 2020
@Tyriar Tyriar merged commit cc09e1d into microsoft:master Jun 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path gets blacked on hover in terminal if hoverHighlightBackground is opaque
2 participants