Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version: jj-vcs.jj to 0.25.0 #207829

Conversation

RoscoP
Copy link
Contributor

@RoscoP RoscoP commented Jan 6, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

=== manifests\j\jj-vcs\jj\0.25.0 ===
Missing Properties value based on version 0.24.0:
ReleaseDate

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) January 6, 2025 19:31
@RoscoP
Copy link
Contributor Author

RoscoP commented Jan 6, 2025

I used wingetcreate update (version 1.9.3.0+16e0c4c7c94b1afff9937f76ac287db01ca52a86) to generate the update and it didn't seem to fill in this field. Is this required?

@stephengillie
Copy link
Collaborator

The schema says this field is optional. @Trenly, should we block on this?

@stephengillie stephengillie added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 7, 2025
@Trenly
Copy link
Contributor

Trenly commented Jan 7, 2025

Since it isn’t something "major" like a missing installer or switches, I think this is fine

@stephengillie stephengillie removed Needs-Attention This work item needs to be reviewed by a member of the core team. Manifest-Metadata-Consistency labels Jan 7, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 7, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4560c51 into microsoft:master Jan 7, 2025
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants