Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures that cmdlets are correctly mapped to their respective modules. #3081

Merged
merged 84 commits into from
Feb 5, 2025
Merged

Ensures that cmdlets are correctly mapped to their respective modules. #3081

merged 84 commits into from
Feb 5, 2025

Conversation

timayabi2020
Copy link
Contributor

@timayabi2020 timayabi2020 commented Jan 21, 2025 •
edited
Loading

Fixes #2957
This PR is a follow up to the solution provided at microsoft/OpenAPI.NET.OData#642 for rectifying incorrect module mapping.

Files changed

  • Refreshed open API files to import new paths.
  • Updated AutoREST directives for User.Actions, Teams, Sites, Security, Reports, Notes, Mail, CloudCommunincations and Devices.Corporate Management modules to address AutoREST module build issues. i.e. Erroneous paths contravening Autorest rules for cmdlet generation.
  • Added functionality for forcefully closing and deleting cached files from previous module generation attempts. The number of open cached files were exceeding the agent's allowable limit of open files.

@timayabi2020 timayabi2020 requested a review from a team as a code owner January 21, 2025 13:36
@timayabi2020 timayabi2020 changed the title Module mapping/fx Ensures that cmdlets are correctly mapped to their respective modules. Jan 21, 2025
@timayabi2020 timayabi2020 marked this pull request as draft January 22, 2025 02:09
Microsoft Graph DevX Tooling added 24 commits January 22, 2025 05:12
Updating module mapping to troubleshoot failing module
870c9e3
Updated test
54f81b5
Disabled test
839bca2
Disabled failing test
1b44e90
Troubleshooting failing module
a50513d
Commented out devices.corporate management
c31d245
Still troubleshooting failures
6ec2e23
Isolating device corporate manageement for troubleshooting
5339b42
Rolled back devices.corporate management beta version
20a8ef2
Isolating DeviceManagement.Administration for analysis
6c52757
Rolled back DeviceManagement.Administration
5818cc4
Rolled back device management
a02b972
Rolled back mail
c9fb086
Removed inexistent mapping
c545039
Rolled back notes
5f21c94
Rolled back beta reports
dd6ccbb
Rolled back security open api files
323dbab
Narrowed troubleshooting scope
1b597dc
Added directive to omit failing cmdlet in sites and narrowed down tro…
f1df187 
…ubleshooing scope
narrowed down troubleshooting scope by adding GroupSiteOnenoteNoteboo…
52069be 
…kSectionPage to sites directive
Narrowed down troubleshooting scope and added GroupSiteOnenoteNoteboo…
3cabd13 
…kSectionPage to exception directive because of errors
Corrected regex
f03d775
Added Update-MgGroupSiteOnenotePage to exception list
ceaf4e7
Added GroupSiteOnenoteSectionGroupSectionPage to exception
06a52c7
Microsoft Graph DevX Tooling and others added 24 commits January 31, 2025 15:31
Removed faulty code in CI
d65bf73
Added try-catch
8e01d5e
Added checks to confirm if a file exists
39be60d
Modified from deleting to forcefully close files
61b56b0
Autodetected temp file folder
81109a4
Updated service module generation to forcefully close files per api v…
fa2bf80 
…ersion
Added throttle limiting
37b426c
Added dynamic throttling
092b507
Removed null pointer inside the loop
281e3c1
Removed parallelism
b64a9ad
Re-enabled parallelism
0702f08
Force remove files
a05a61e
Added closing of files recursively
d7d99bc
Defined function first before using it
9316248
Defined the function within the foreach scope
49d1ef8
Reduced the throttle limit
578a97d
Rolled back devicemanagement
578a8b4
Rolled back devicemanagement
eb9cd30
Added using
0000597
Rolled back beta version of managed tenants
e23f9ea
Removing more cached files
c4427f0
Updated modules mapping to remove modules that are causing duplicate …
653a79c 
…cmdlets
Updated modules mapping to remove modules that are causing duplicate …
659db09 
…cmdlets
@timayabi2020
Merge branch 'dev' into module-mapping/fx
9b710e5
@timayabi2020 timayabi2020 marked this pull request as ready for review February 3, 2025 04:42
@timayabi2020 timayabi2020 merged commit b299e2b into dev Feb 5, 2025
3 of 6 checks passed
@timayabi2020 timayabi2020 deleted the module-mapping/fx branch February 5, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect module mapping on Graph PowerShell documentation
2 participants
@timayabi2020 @Ndiritu