Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIH MSIRS 24-25 submission #45

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Conversation

sunky1016
Copy link
Contributor

No description provided.

Copy link

Run validation on files: 2024-07-28-NIH-RSV_MSIRS.gz.parquet

Required values:

No missing required value found

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 5043: All values associated with output type 'sample' should have a maximum of 1 decimal place

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional), inc inf (optional), cum inf (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

Column Pairing information:

Run grouping pairing:
No run grouping
Stochastic run pairing:
c("scenario_id", "age_group", "horizon", "location")
Number of Samples: 100

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin LucieContamin self-requested a review December 2, 2024 14:40
Copy link
Contributor

@LucieContamin LucieContamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sunky1016 ,
Thank you for your projections, I just wanted to confirm I read the pairing information correctly: the only difference between each run is stochasticity (run_grouping all the same value (0)) and the stochastic runs are grouped by scenario, location, horizon, age group.
Is that correct?

Thanks, Lucie

@sunky1016
Copy link
Contributor Author

sunky1016 commented Dec 2, 2024 via email

@LucieContamin
Copy link
Contributor

THanks for the quick reply,
If it's possible to resubmit that would be helpful.

Many thanks,
Best, Lucie

Copy link

github-actions bot commented Dec 2, 2024

Run validation on files: 2024-07-28-NIH-RSV_MSIRS.gz.parquet

Required values:

No missing required value found

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 5043: All values associated with output type 'sample' should have a maximum of 1 decimal place

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional), inc inf (optional), cum inf (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

Column Pairing information:

Run grouping pairing:
c("scenario_id", "age_group", "horizon", "location")
Stochastic run pairing:
No stochasticity
Number of Samples: 100

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin
Copy link
Contributor

Thank you very much for the update!

@sunky1016
Copy link
Contributor Author

Hi Lucie,

I have resubmitted my projections fixing the issue of run grouping and stochastic runs. Let me know if there are additional issues!

@LucieContamin LucieContamin merged commit a421d8e into midas-network:main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants