Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU submission #7

Merged
merged 10 commits into from
Dec 7, 2023
Merged

CU submission #7

merged 10 commits into from
Dec 7, 2023

Conversation

tkcy
Copy link
Contributor

@tkcy tkcy commented Dec 6, 2023

No description provided.

Copy link

github-actions bot commented Dec 6, 2023

[1] "Run validation on file: 2023-11-12-CU-RSV_SVIRS.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin
Copy link
Contributor

LucieContamin commented Dec 6, 2023

Good afternoon @tkcy ,

Thank you very much for your submission.
Would it be possible to also provide a metadata file with your first submission, please?
The file should be in a .yaml format in the model-metadata folder, please find here some documentation and examples files: https://github.com/midas-network/rsv-scenario-modeling-hub/tree/main/model-metadata

Please feel free to let me know if any issues or questions,

Thanks,
Lucie

@tkcy
Copy link
Contributor Author

tkcy commented Dec 7, 2023

@LucieContamin added metadata!

Copy link

github-actions bot commented Dec 7, 2023

[1] "Run validation on file: 2023-11-12-CU-RSV_SVIRS.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin
Copy link
Contributor

@tkcy thank you very much!

Just a small notice:

  • For the model contributors section, it will be used on the website so if you want to use full first and last name or any different format (compared to the examples), it is accepted. I will use it on the website as in the same format as provided in the metadata.

  • Also the team-funding, data_inputs, methods_long and citation are optional additional field so if you don't have to provide them all. For example, it seems that you don't have a citation, the format you use is all good, it's also accepted to remove it from the yaml file.

As they are small notice, I can merge the PR as it is currently or leave it open if you want to do another update to the metadata file.
Please feel free to let me know if any issues or questions,

Thanks,
Lucie

@tkcy
Copy link
Contributor Author

tkcy commented Dec 7, 2023

@LucieContamin thanks! I actually realized I uploaded a different version of the file that I must have made earlier and forgotten about! I made some updates, and am happy with it if you are!

Copy link

github-actions bot commented Dec 7, 2023

[1] "Run validation on file: 2023-11-12-CU-RSV_SVIRS.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

Copy link

github-actions bot commented Dec 7, 2023

[1] "Run validation on file: 2023-11-12-CU-RSV_SVIRS.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin
Copy link
Contributor

@tkcy , thank you for the updates! I think it looks all good to me, I will merge the PR!

@LucieContamin LucieContamin merged commit 344b036 into midas-network:main Dec 7, 2023
1 check passed
@LucieContamin
Copy link
Contributor

Hi @tkcy ,

I just wanted to verify the "sample" run_grouping and stochastic_run columns information if that's ok. It seems that each model run has a run_grouping set grouped by age_group, horizon, scenario_id replicated in multiple stochastic run. The different scenarios are assumed to share the same stochastic runs. Is that correct?

Please feel free to let me know if any issues or questions,

Thanks,
Lucie

@tkcy
Copy link
Contributor Author

tkcy commented Dec 8, 2023

Hi Lucie! Each location has a set of stochastic runs - these have continuity across age groups and horizons. The model begins with the stochastic initialization across scenarios and diverges because of the interventions but there is a possibility of additional divergence if/when one of the runs goes out of bounds during the model fitting stage. I wasn't entirely sure how to indicate this since it's still mostly shared but possibility of slight difference.
Thanks,
Teresa

@LucieContamin
Copy link
Contributor

Hi Teresa,

Thank you very much for the quick answer and for the explanation, I agree that the format you use is the best option to represent it
Thanks,
Lucie

@tkcy
Copy link
Contributor Author

tkcy commented Dec 11, 2023

@LucieContamin Hi! just a heads up that we're trying out a slightly altered version of the model where we fit the model once and then apply the different interventions after the fitting is complete in order to better isolate the effects of the interventions. This should be ready in the next day or two. Thanks!

@LucieContamin
Copy link
Contributor

Hi @tkcy ! Thank you for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants