Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USC-SIkJalpha Update - Added Missing US Forecasts #8

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

maa989
Copy link
Contributor

@maa989 maa989 commented Dec 8, 2023

No description provided.

Copy link

github-actions bot commented Dec 8, 2023

[1] "Run validation on file: 2023-11-12-USC-SIkJalpha.parquet"

Copy link

github-actions bot commented Dec 8, 2023

If the submission contains a projection file, a pdf containing the visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@LucieContamin
Copy link
Contributor

Good morning @maa989,

Thank you for your update, It seems that the validation had an issue. It seems to be link to the format of the "run_grouping" column, it seems to be in a list format. Will it be possible to verify it please?

Please let me know if any issues or questions,
Best,
Lucie

@LucieContamin
Copy link
Contributor

Also, I just wanted to verify the "sample" run_grouping and stochastic_run columns. It seems that each model run has a different run_grouping set grouped by age_group, horizon , scenario_id and location (model run independent) and the runs are not stochastic (no stochasticity), is it correct?

Please feel free to let me know if any issues or questions,

Thanks,
Lucie

Copy link

github-actions bot commented Dec 8, 2023

[1] "Run validation on file: 2023-11-12-USC-SIkJalpha.parquet"

Copy link

github-actions bot commented Dec 8, 2023

If the submission contains a projection file, a pdf containing the visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

Copy link

github-actions bot commented Dec 8, 2023

[1] "Run validation on file: 2023-11-12-USC-SIkJalpha.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

❌ Error 302: 'origin_date' should contains 1 unique date. The file contains multiple `origin_date' values: '2023-11-12, 2022-02-09'.
❌ Error 303: 'origin_date' is not corresponding to the name in the file, the 'origin_date' date value and the date in the filename should correspond to: 'origin_date'.

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 606: The projection contains more projected week than expected. The additional weeks might not be included in the Ensembles and/or visualizations

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

Copy link

github-actions bot commented Dec 8, 2023

If the submission contains a projection file, a pdf containing the visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

Copy link

github-actions bot commented Dec 8, 2023

[1] "Run validation on file: 2023-11-12-USC-SIkJalpha.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

❌ Error 302: 'origin_date' should contains 1 unique date. The file contains multiple `origin_date' values: '2023-11-12, 2022-02-09'.
❌ Error 303: 'origin_date' is not corresponding to the name in the file, the 'origin_date' date value and the date in the filename should correspond to: 'origin_date'.

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 606: The projection contains more projected week than expected. The additional weeks might not be included in the Ensembles and/or visualizations

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

Copy link

github-actions bot commented Dec 8, 2023

If the submission contains a projection file, a pdf containing the visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

Copy link

github-actions bot commented Dec 8, 2023

[1] "Run validation on file: 2023-11-12-USC-SIkJalpha.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 606: The projection contains more projected week than expected. The additional weeks might not be included in the Ensembles and/or visualizations

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

Copy link

github-actions bot commented Dec 8, 2023

If the submission contains a projection file, a pdf containing the visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@maa989
Copy link
Contributor Author

maa989 commented Dec 8, 2023

Hello @LucieContamin I have updated the submission to fix the formatting issue with run_grouping and one other issue with the origin_date. It should be good now. As for your other questions, yes your understanding of the grouping is correct. And there is no stochasticity.

@LucieContamin
Copy link
Contributor

Hi again!
Thank you very much for the update and for the answer! It looks all good, I will merge the PR.

Best,
Lucie

@LucieContamin LucieContamin merged commit 943d4a5 into midas-network:main Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants