Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable override on API keys for external services #7

Merged
merged 12 commits into from
Mar 12, 2024
Merged

Enable override on API keys for external services #7

merged 12 commits into from
Mar 12, 2024

Conversation

thelgason
Copy link
Contributor

@thelgason thelgason commented Feb 28, 2024 •
edited
Loading

Support override on API keys for external services on a request basis

@thelgason thelgason requested a review from sultur February 28, 2024 10:35
sultur
sultur requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@sultur sultur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good! Mostly just minor nitpicks from me. Are you developing with pre-commit enabled too? Ruff should catch minor stuff like the f-string thing, and it ensures that all our stuff is formatted in the same way.

.python-version Outdated Show resolved Hide resolved
src/icespeak/voices/aws_polly.py Outdated Show resolved Hide resolved
src/icespeak/voices/azure.py Outdated Show resolved Hide resolved
@thelgason thelgason marked this pull request as ready for review March 7, 2024 15:24
sultur
sultur approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@sultur sultur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!! I'm only curious about whether the __eq__ and __hash__ methods are needed for Keys.
Edit: LGTM, this can be merged once ready.

src/icespeak/settings.py Show resolved Hide resolved
tests/test_tts.py Outdated Show resolved Hide resolved
@thelgason thelgason merged commit 25e2866 into master Mar 12, 2024
10 checks passed
@thelgason thelgason deleted the keys_override branch March 12, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sultur sultur sultur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelgason @sultur