MDL-63785 core_portfolio: performance improvement

mifantrax · Dec 10, 2018 · 28dfbe7 · 28dfbe7
1 parent cb624f4
commit 28dfbe7
Showing 1 changed file with 7 additions and 18 deletions.
diff --git a/portfolio/classes/privacy/provider.php b/portfolio/classes/privacy/provider.php
@@ -113,27 +113,16 @@ public static function get_users_in_context(userlist $userlist) {
             return;
         }
 
-        $params = [
-            'contextid' => $context->id,
-            'contextuser' => CONTEXT_USER,
-        ];
-
-        $sql = "SELECT ctx.instanceid as userid
-                  FROM {portfolio_instance_user} piu
-                  JOIN {context} ctx
-                       ON ctx.instanceid = piu.userid
-                       AND ctx.contextlevel = :contextuser
-                 WHERE ctx.id = :contextid";
+        $params = [$context->instanceid];
 
+        $sql = "SELECT userid
+                  FROM {portfolio_instance_user}
+                 WHERE userid = ?";
         $userlist->add_from_sql('userid', $sql, $params);
 
-        $sql = "SELECT ctx.instanceid as userid
-                  FROM {portfolio_log} pl
-                  JOIN {context} ctx
-                       ON ctx.instanceid = pl.userid
-                       AND ctx.contextlevel = :contextuser
-                  WHERE ctx.id = :contextid";
-
+        $sql = "SELECT userid
+                  FROM {portfolio_log}
+                  WHERE userid = ?";
         $userlist->add_from_sql('userid', $sql, $params);
     }