Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "hooks" and "constants" folders #251

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Conversation

iJuulia
Copy link
Contributor

@iJuulia iJuulia commented Oct 4, 2024

No description provided.

@sebastiandotdev
Copy link

Hello @iJuulia,

I think you need to add the folder-hooks and folder-constants icon to the “iconDefinitions”: { } object.

@sebastiandotdev
Copy link

@miguelsolorio I support the idea of the icons, it seems to me that it goes according to the design that you manage.

@iJuulia
Copy link
Contributor Author

iJuulia commented Oct 6, 2024

You are right, thanks for pointing that out. I fixed it :)

@miguelsolorio
Copy link
Owner

@iJuulia thanks for the PR, please add a screenshot of the extension running with these new additions. Thanks.

Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-10-25 at 14 46 38@2x

Made some minor color and size changes, also fixed some broken paths. Please ensure you test this locally next time and attach a screenshot. Thanks!

@miguelsolorio miguelsolorio merged commit fee6e9f into miguelsolorio:main Oct 25, 2024
1 check passed
@miguelsolorio miguelsolorio self-assigned this Oct 25, 2024
@miguelsolorio miguelsolorio added icon request Request for a new icon and removed response needed labels Oct 25, 2024
@miguelsolorio miguelsolorio added this to the 0.0.21 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request Request for a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants