Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'expo' and 'gradle' folders #259

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Pedroo-Nietoo
Copy link
Contributor

What does this PR add to the project?

This commit adds two new folders to the extension: the expo and gradle folders.

The Figma file with the new folders can be found by clicking here.

Print with the icons working

image

Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks like the expo icon does not look good in dark themes. Can you update the color to use one of the other gray colors from other icons (github, next, etc.)? Those tend to work better in dark/light themes.

@Pedroo-Nietoo
Copy link
Contributor Author

Sure! I'll update it and upload it again.

@Pedroo-Nietoo
Copy link
Contributor Author

Pedroo-Nietoo commented Oct 30, 2024

@miguelsolorio I fixed the expo icon color according to the GitHub folder color pallete. Is it good?

image

@miguelsolorio
Copy link
Owner

Much better, thank you!

@miguelsolorio miguelsolorio added icon request Request for a new icon and removed response needed labels Nov 22, 2024
@miguelsolorio miguelsolorio merged commit e5e9bfe into miguelsolorio:main Nov 22, 2024
1 check passed
@miguelsolorio miguelsolorio modified the milestones: 0.0.21, 0.0.22 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request Request for a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants