Merge pull request #194 from brianmay/fix_187

Ensure we don't access this.states.color.spectrumHsv if undefined
mikejac · Oct 1, 2021 · 6ea481a · 6ea481a
2 parents c87c8b8 + b750406
commit 6ea481a
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/devices/light.js b/devices/light.js
@@ -1997,9 +1997,14 @@ module.exports = function(RED) {
                     let brightness  = this.is_dimmable ? this.states.brightness : undefined;
                     let rgb         = this.is_rgb ? this.states.color.spectrumRgb: undefined;
                     let temperature = this.has_temp ? this.states.color.temperatureK : undefined;
-                    let hue         = this.is_hsv ?  this.states.color.spectrumHsv.hue : undefined;
-                    let saturation  = this.is_hsv ?  this.states.color.spectrumHsv.saturation : undefined;
-                    let value       = this.is_hsv ?  this.states.color.spectrumHsv.value : undefined;
+                    let hue         = undefined;
+                    let saturation  = undefined;
+                    let value       = undefined;
+                    if (this.is_hsv && this.states.color.spectrumHsv != null) {
+                        hue = this.states.color.spectrumHsv.hue;
+                        saturation = this.states.color.spectrumHsv.saturation;
+                        value = this.states.color.spectrumHsv.value;
+                    }
 
                     let differs = false;