Improve caching during build #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves caching even if build stage is completely rewritten
The packages installed are the same, why download things twice. Also, DEBIAN_FRONTEND is dropped, it's not necessary at this point.
|
@milaq: I think this is good to merge. I got things done I needed to (xbmc/xbmc#16777 (comment)). Thanks for having a baseline for this. I might submit more changes in the future. |
milaq
reviewed
Nov 10, 2019
milaq
reviewed
Nov 10, 2019
There was a problem hiding this comment.
The packages we install in the deploystage differ from the buildstage as we install only the necessary packages in order to run Kodi without any development packages.
This way the resulting image itself is way smaller.
As I put together the package list I wasn't paying close attention to overlaps.
Maybe we need to have a look at the package list again and find similarities.
|
Thanks for your endeavours and sorry for the review delay; I am quite busy with RL atm :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves caching even if build stage is completely rewritten. The commands have been re-ordered to improve caching and prevent extra repeated downloads.
Commit messages explain the best.