-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add configs for compaction schedule #39010
base: master
Are you sure you want to change the base?
enhance: Add configs for compaction schedule #39010
Conversation
Signed-off-by: yangxuan <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: XuanYang-cn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@XuanYang-cn go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39010 +/- ##
==========================================
- Coverage 81.18% 81.16% -0.02%
==========================================
Files 1390 1390
Lines 196755 196782 +27
==========================================
- Hits 159732 159727 -5
- Misses 31442 31472 +30
- Partials 5581 5583 +2
|
Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn go-sdk check failed, comment |
@XuanYang-cn cpp-unit-test check failed, comment |
configs/milvus.yaml
Outdated
scheduleInterval: 1000 # The time interval in milliseconds for scheduling compaction tasks. If the configuration setting is below 100ms, it will be ajusted upwards to 100ms | ||
checkInterval: 1000 # The time interval in milliseconds for checking compaction tasks. If the configuration setting is below 100ms, it will be ajusted upwards to 100ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this PR: schedulerInterval and checkInteval is 3s
Not sure if we should set default to
- 500ms as in this PR
- 3000 the same as before.
Signed-off-by: yangxuan <[email protected]>
rerun ut |
No description provided.