Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add configs for compaction schedule #39010

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

XuanYang-cn
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 6, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 6, 2025
Copy link
Contributor

mergify bot commented Jan 6, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.16%. Comparing base (aceb972) to head (15c439f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/paramtable/component_param.go 76.92% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39010      +/-   ##
==========================================
- Coverage   81.18%   81.16%   -0.02%     
==========================================
  Files        1390     1390              
  Lines      196755   196782      +27     
==========================================
- Hits       159732   159727       -5     
- Misses      31442    31472      +30     
- Partials     5581     5583       +2     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.53% <ø> (ø)
Go 83.12% <80.64%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 69.75% <100.00%> (-1.35%) ⬇️
pkg/util/paramtable/component_param.go 98.25% <76.92%> (-0.14%) ⬇️

... and 25 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 8, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 8, 2025
Comment on lines 573 to 574
scheduleInterval: 1000 # The time interval in milliseconds for scheduling compaction tasks. If the configuration setting is below 100ms, it will be ajusted upwards to 100ms
checkInterval: 1000 # The time interval in milliseconds for checking compaction tasks. If the configuration setting is below 100ms, it will be ajusted upwards to 100ms
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR: schedulerInterval and checkInteval is 3s

Not sure if we should set default to

  • 500ms as in this PR
  • 3000 the same as before.

@mergify mergify bot added ci-passed and removed ci-passed labels Jan 9, 2025
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added ci-passed and removed ci-passed labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants