include MFA in frame

mimiquate · Jun 11, 2024 · 14ae66b · 14ae66b
1 parent 3920896
commit 14ae66b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/tower_rollbar/rollbar/item.ex b/lib/tower_rollbar/rollbar/item.ex
@@ -100,8 +100,10 @@ defmodule TowerRollbar.Rollbar.Item do
 
   defp frames(stacktrace) do
     stacktrace
-    |> Enum.map(fn {_m, _f, _a, location} ->
-      frame = %{}
+    |> Enum.map(fn {m, f, a, location} ->
+      frame = %{
+        "method" => Exception.format_mfa(m, f, a)
+      }
 
       frame =
         if location[:file] do

diff --git a/test/tower_rollbar/rollbar/item_test.exs b/test/tower_rollbar/rollbar/item_test.exs
@@ -24,18 +24,22 @@ defmodule TowerRollbar.Rollbar.ItemTest do
                  "trace" => %{
                    "frames" => [
                      %{
+                       "method" => _,
                        "filename" => "lib/ex_unit/runner.ex",
                        "lineno" => _
                      },
                      %{
+                       "method" => _,
                        "filename" => "timer.erl",
                        "lineno" => _
                      },
                      %{
+                       "method" => _,
                        "filename" => "lib/ex_unit/runner.ex",
                        "lineno" => _
                      },
                      %{
+                       "method" => ~s(TowerRollbar.Rollbar.ItemTest."test from_exception"/1),
                        "filename" => "test/tower_rollbar/rollbar/item_test.exs",
                        "lineno" => 12
                      }