Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADA-SVR (4/4) bis: adding type and assertion #102

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

lionelkusch
Copy link
Collaborator

This pull request includes a modification of other PR (#74, #73, #99, #100, #101)

This pull request is an example of adding types and assertions to a model.

It can be used as an example of the possibility for #96.

lionelkusch and others added 30 commits December 13, 2024 16:37
Remove the error because it's not possible to access it due to the operation of np.dot(X, X.T) on line 39. The only line using this function.
variable unnecessary and without meaning in this context
Add comment about the condition of X from the removal lines
fix typo errors

Co-authored-by: bthirion <[email protected]>
@bthirion
Copy link
Contributor

The issue is that the diff from this PR includes also the diff of PR #100. How do you want to proceed ? Close #100 and go on with that one ? or wait till #100 is merged ?

@lionelkusch
Copy link
Collaborator Author

The issue is that the diff from this PR includes also the diff of PR #100. How do you want to proceed ? Close #100 and go on with that one ? or wait till #100 is merged ?

I prefer to wait until the #100 is merged. It's a sequence of 5 PR.

@lionelkusch lionelkusch mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants