Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data sources in bundles #5301

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

eleftherias
Copy link
Contributor

Summary

This allows Minder to create data sources from a bundle when a new user registers.

A part of this PR involves changing the parameter type in several functions from a db.Querier to a db.ExtendQuerier, making it more specific.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner January 14, 2025 09:08
@eleftherias eleftherias force-pushed the data-source-marketplace branch from fdfded5 to cde2fc1 Compare January 14, 2025 09:10
@coveralls
Copy link

coveralls commented Jan 14, 2025

Coverage Status

coverage: 56.751% (+0.1%) from 56.631%
when pulling cde2fc1 on eleftherias:data-source-marketplace
into 0a089be on mindersec:main.

@eleftherias eleftherias merged commit 8373b80 into mindersec:main Jan 14, 2025
26 checks passed
@eleftherias eleftherias deleted the data-source-marketplace branch January 14, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants