Adds check to ensure config file exists. Fixes: #4513

cmd/cli/app/root.go

@@ -104,42 +104,58 @@ func initConfig() {
 	viper.SetEnvPrefix("minder")
 	viper.SetEnvKeyReplacer(strings.NewReplacer(".", "_", "-", "_"))
 
-	cfgFilePath := cli.GetRelevantCLIConfigPath(viper.GetViper())
-	if cfgFilePath != "" {
-		cfgFileData, err := config.GetConfigFileData(cfgFilePath)
-		if err != nil {
-			RootCmd.PrintErrln(err)
+	// Get the config flag value directly to ensure we catch explicitly specified configs
+	configFlag := viper.GetString("config")
+	if configFlag != "" {
+		// User explicitly specified a config file via --config flag
+		if _, err := os.Stat(configFlag); err != nil {
+			RootCmd.PrintErrln(fmt.Sprintf("Cannot find specified config file: %s", configFlag))
 			os.Exit(1)
 		}
-
-		keysWithNullValue := config.GetKeysWithNullValueFromYAML(cfgFileData, "")
-		if len(keysWithNullValue) > 0 {
-			RootCmd.PrintErrln("Error: The following configuration keys are missing values:")
-			for _, key := range keysWithNullValue {
-				RootCmd.PrintErrln("Null Value at: " + key)
-			}
-			os.Exit(1)
-		}
-
-		viper.SetConfigFile(cfgFilePath)
+		viper.SetConfigFile(configFlag)
 	} else {
-		// use defaults
+		// No config file specified, use defaults
 		viper.SetConfigName("config")
 		viper.AddConfigPath(".")
 		if cfgDirPath := cli.GetDefaultCLIConfigPath(); cfgDirPath != "" {
 			viper.AddConfigPath(cfgDirPath)
 		}
 	}
+
 	viper.SetConfigType("yaml")
 	viper.AutomaticEnv()
 
 	if err := viper.ReadInConfig(); err != nil {
+		if configFlag != "" {
+			// If there's any error, we should fail
+			RootCmd.PrintErrln(fmt.Sprintf("Error reading config file %s: %v", configFlag, err))
+			os.Exit(1)
+		}
+
 		if _, ok := err.(viper.ConfigFileNotFoundError); ok {
-			// Config file not found; use default values
+			// Only allow "config not found" when no config was explicitly specified
 			RootCmd.PrintErrln("No config file present, using default values.")
 		} else {
-			// Some other error occurred
-			RootCmd.Printf("Error reading config file: %s", err)
+			RootCmd.PrintErrln(fmt.Sprintf("Error reading config file: %s", err))
+			os.Exit(1)
+		}
+	}
+
+	// If we successfully read a config file, check for null values
+	if configFlag != "" {
+		cfgFileData, err := config.GetConfigFileData(configFlag)
+		if err != nil {
+			RootCmd.PrintErrln(fmt.Sprintf("Error reading config file data: %v", err))
+			os.Exit(1)
+		}
+
+		keysWithNullValue := config.GetKeysWithNullValueFromYAML(cfgFileData, "")
+		if len(keysWithNullValue) > 0 {
+			RootCmd.PrintErrln("Error: The following configuration keys are missing values:")
+			for _, key := range keysWithNullValue {
+				RootCmd.PrintErrln("Null Value at: " + key)
+			}
+			os.Exit(1)
 		}
 	}
 }