Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sdv2 to ms2.3 #626

Merged
merged 10 commits into from
Sep 12, 2024
Merged

update sdv2 to ms2.3 #626

merged 10 commits into from
Sep 12, 2024

Conversation

Songyuanwei
Copy link
Collaborator

@Songyuanwei Songyuanwei commented Aug 9, 2024 •
edited
Loading

What does this PR do?

  1. update sdv2 code for mindspore 2.3.
  2. test performance and update readme
  3. fix ema bug when offloading=True.

remaining problems：

  1. ms2.3_lite infer.

Fixes # (issue) #618

Adds # (feature)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@Songyuanwei Songyuanwei changed the title update sdv2 for ms2.3 update sdv2 to ms2.3 Aug 22, 2024
SamitHuang
SamitHuang reviewed Sep 10, 2024
View reviewed changes
examples/stable_diffusion_v2/inpaint.py Outdated
device_target="Ascend",
device_id=device_id,
max_device_memory="30GB",
)
if args.ms_mode == ms.GRAPH_MODE:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put set_env into one common function

@SamitHuang SamitHuang added this pull request to the merge queue Sep 12, 2024
Merged via the queue into mindspore-lab:master with commit 7159716 Sep 12, 2024
3 checks passed
@Songyuanwei Songyuanwei deleted the sdsd_ms2.3 branch December 24, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamitHuang SamitHuang SamitHuang approved these changes

@CaitinZhao CaitinZhao CaitinZhao approved these changes

@zhanghuiyao zhanghuiyao Awaiting requested review from zhanghuiyao zhanghuiyao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Songyuanwei @SamitHuang @CaitinZhao