zero doc & checkpoint save adapt #834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhtmike
reviewed
Feb 14, 2025
| @property | ||
| def bias(self): | ||
| return self.net.bias | ||
|
|
There was a problem hiding this comment.
may change if self.net.has_bias -> if self.bias is not None since mint.Conv does not have has_bias attribute
vigo999
approved these changes
Feb 18, 2025
SamitHuang
approved these changes
Feb 18, 2025
zhtmike
reviewed
Feb 19, 2025
| if self.ckpt_combine_online: | ||
| new_net_to_save = self._do_ckpt_combine_online() | ||
|
|
||
| if self.self.need_save_network: |
There was a problem hiding this comment.
double self.
This script is not tested, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx