Created a retry mechanism and added a --retry flag to mc mirror #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Oct 14, 2023
klauspost
reviewed
Oct 14, 2023
looks good Co-authored-by: Klaus Post <[email protected]>
Co-authored-by: Klaus Post <[email protected]>
Co-authored-by: Klaus Post <[email protected]>
harshavardhana
approved these changes
Oct 16, 2023
klauspost
approved these changes
Oct 17, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
There are failure cases when doing transfers that are not recoverable in the minio-go library. These cases can be recovered from at a higher level (more specifically in the mc client). This pull request implements a very basic retry mechanism which can be used to encapsulate any logic.
Notes
The retry mechanism is only encapsulating the mc mirror command for now. But we could expand it to encapsulate all transfers, eventually.
There are a few github issues which have been reported with failure cases (not bugs) which might be avoided with this retry mechanism:
#4635
#4231
#3075
#3965 (this one might have been a filesystem issue)
#4138
#4202
How to test this PR?
Types of changes