restructure credential creation with simplified expectations #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
harshavardhana
force-pushed
the
restructure
branch
from
24d7a33 to
d33a187
Compare
taran-p
requested changes
May 21, 2024
avoid weird coding style, simplify by using relatively less number of variables and move things around to make code more readable. improve HELP output readability.
harshavardhana
force-pushed
the
restructure
branch
from
d33a187 to
33cad5b
Compare
Co-authored-by: Taran Pelkey <[email protected]>
taran-p
approved these changes
May 23, 2024
Co-authored-by: Shubhendu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
restructure credential creation with simplified expectations
Motivation and Context
Avoid weird coding styles, and simplify by using a relatively small
number of variables, and move things around to make code more readable.
Improve HELP output readability.
How to test this PR?
Generally, should fix some low-hanging bugs in these CLIs.
Types of changes
Checklist:
commit-idorPR #here)